I got out of the army last year. Here’s my perspective/advice:
1. If you eventually want a job with a 3 letter agency, get a job in the military (whichever branch you want) that will get you a TS clearance. By signing up for the TS -associated job the military will pay for the whole TS application process, and when you decide to leave the service you have a HUGE leg up on other applicants for your government job of choice. Your best bet job wise is to go intel. They are highly competitive though, especially for officers. Your academic success in college plays a big role in what branch options you have as an officer.
2. You probably won’t deploy. And if you do it’ll be FOB ops and f***ery. Could be a good or bad thing depending on personal preference.
3. It’s peacetime right now. IMO we haven’t been at war for years. Afghanistan is an occupation, not a war. Peacetime military gets real dumb real quick. If you have higher aspirations than the military, use it as a stepping stone and don’t get weighed down too much by the nonsense. In 4-6 years you’ll look back and be glad you did it, but also glad you don’t have to do it ever again.