Well without a doubt this is collusion with the Russians and it also violates a campaign funding rule about accepting things of value to help your campaign from a foreign country.
This wasn't just Jr. being an idiot. Trump's son-in-law and his campaign manager also went to this meeting and knew the purpose of this meeting to obtain information (dirt) from the Russians.
There were not only verbal lies about this meeting but signed forms failing to reveal this and other meetings. That is illegal to misrepresent information on these legal forms.
This is not a 'nothing burger". Russian collusion is real. It all points to the president too. He even claimed to be receiving inside information on Hillary shortly after this meeting was scheduled. Pence is distancing him from this mess, getting prepared to take over.
Trump will be very busy in the next couple years (if he lasts) making presidential pardons.